enb metric bound check. Fix of heap-buffer overflow issue

4 years ago · 442843e276
parent 53116a99fc
commit 442843e276
1 changed files with 1 additions and 2 deletions
--- a/srsenb/src/metrics_stdout.cc
+++ b/srsenb/src/metrics_stdout.cc
@ -89,8 +89,7 @@ void metrics_stdout::set_metrics(const enb_metrics_t& metrics, const uint32_t pe

  for (size_t i = 0; i < metrics.stack.rrc.ues.size(); i++) {
    // make sure we have stats for MAC and PHY layer too
-    if (metrics.stack.mac.ues.size() == 0 || metrics.phy.size() == 0 || i > metrics.stack.mac.ues.size() ||
-        i > metrics.phy.size()) {
+    if (i >= metrics.stack.mac.ues.size() || i >= metrics.phy.size()) {
      break;
    }
    if (metrics.stack.mac.ues[i].tx_errors > metrics.stack.mac.ues[i].tx_pkts) {