diff --git a/lib/include/srslte/common/logger.h b/lib/include/srslte/common/logger.h index 6e1d101e6..b79a8617f 100644 --- a/lib/include/srslte/common/logger.h +++ b/lib/include/srslte/common/logger.h @@ -40,6 +40,7 @@ public: const static uint32_t preallocated_log_str_size = 1024; logger() : pool(16 * 1024) {} + virtual ~logger() = default; class log_str { diff --git a/lib/include/srslte/common/threads.h b/lib/include/srslte/common/threads.h index f07c41244..a5bd52c37 100644 --- a/lib/include/srslte/common/threads.h +++ b/lib/include/srslte/common/threads.h @@ -47,7 +47,6 @@ void threads_print_self(); #include namespace srslte { -; class thread { @@ -64,6 +63,8 @@ public: other.name = ""; } + virtual ~thread() = default; + thread& operator=(const thread&) = delete; thread& operator=(thread&&) noexcept = delete; diff --git a/srsenb/hdr/phy/prach_worker.h b/srsenb/hdr/phy/prach_worker.h index 055586cea..1e0d2a848 100644 --- a/srsenb/hdr/phy/prach_worker.h +++ b/srsenb/hdr/phy/prach_worker.h @@ -34,7 +34,6 @@ class prach_worker : srslte::thread { public: prach_worker(uint32_t cc_idx_) : buffer_pool(8), thread("PRACH_WORKER") { cc_idx = cc_idx_; } - ~prach_worker(); int init(const srslte_cell_t& cell_, const srslte_prach_cfg_t& prach_cfg_, diff --git a/srsenb/src/phy/prach_worker.cc b/srsenb/src/phy/prach_worker.cc index e8b1e5e50..4fa4404f4 100644 --- a/srsenb/src/phy/prach_worker.cc +++ b/srsenb/src/phy/prach_worker.cc @@ -24,8 +24,6 @@ namespace srsenb { -prach_worker::~prach_worker() = default; - int prach_worker::init(const srslte_cell_t& cell_, const srslte_prach_cfg_t& prach_cfg_, stack_interface_phy_lte* stack_, diff --git a/srsue/hdr/phy/phy.h b/srsue/hdr/phy/phy.h index e942a16df..8f21df510 100644 --- a/srsue/hdr/phy/phy.h +++ b/srsue/hdr/phy/phy.h @@ -39,7 +39,7 @@ namespace srsue { typedef _Complex float cf_t; -class phy : public ue_lte_phy_base, public srslte::thread +class phy final : public ue_lte_phy_base, public srslte::thread { public: explicit phy(srslte::logger* logger_) : logger(logger_), workers_pool(MAX_WORKERS), common(), thread("PHY"){};